但是我只想在尝试创建metricA构建器对象时仅调用一次?我怎样才能做到这一点?
最直接的方法是在构建器中具有一个标志,指示该标志是
Record通过克隆还是通过克隆创建的:
class Builder { final boolean cloned; Builder(MetricHolder packet) { this.cloned = true; // ... } Builder(Record record) { this.cloned = false; // ... }}然后,在的构造函数中
MetricHolder:
if (!builder.cloned) { SendData.getInstance().whatever();}但是值得指出的是,进行此调用
SendData是在构造函数中进行过多工作的一个示例。您应该仔细考虑是否真的要在构造函数中进行此调用,或者是否可以将其分解为另一个方法。
其次,我在MetricHolder构造函数中用两个必填字段填充clientPayload映射的方式对我来说不合适。还有其他更好的方法可以做同样的事情吗?
您误解了使用的“
Collections.unmodifiableMap无法修改”的地方:它只是map参数的不可修改 视图
;您仍然可以修改基础地图。
这是一个JUnit测试来演示:
Map<String, String> original = new HashMap<>();original.put("hello", "world");// Obviously false, we just put something into it.assertFalse(original.isEmpty());Map<String, String> unmodifiable = Collections.unmodifiableMap(original);// We didn't modify the original, so we don't expect this to have changed.assertFalse(original.isEmpty());// We expect this to be the same as for the original.assertFalse(unmodifiable.isEmpty());try { unmodifiable.clear(); fail("Expected this to fail, as it's unmodifiable");} catch (UnsupportedOperationException expected) {}// Yep, still the same contents.assertFalse(original.isEmpty());assertFalse(unmodifiable.isEmpty());// But here's where it gets sticky - no exception is thrown.original.clear();// Yep, we expect this...assertTrue(original.isEmpty());// But - uh-oh - the unmodifiable map has changed!assertTrue(unmodifiable.isEmpty());事实是,只有在没有其他参考时,地图才是不可修改的:如果您没有对的引用
original,那么
unmodifiable实际上是不可修改的;否则,您将无法依靠地图永远不变。
在特定情况下,您只是将
clientPayload地图包装在不可修改的集合中。因此,您将覆盖先前构造的实例的值。
例如:
MetricHolder.Builder builder = new MetricHolder.Builder();MetricHolder first = builder.build();assertEquals("false", first.clientPayload.get("is_clientid"));assertEquals("true", first.clientPayload.get("is_deviceid"));builder.setClientId("").build();// Hmm, first has changed.assertEquals("true", first.clientPayload.get("is_clientid"));assertEquals("false", first.clientPayload.get("is_deviceid"));正确的方法是不要包装
builder.clientPayload。制作地图副本,对其进行修改,然后使用
unmodifiableMap:
{ Map<String, String> copyOfClientPayload = new HashMap<>(builder.clientPayload); copyOfClientPayload.put("is_clientid", (clientId == null) ? "false" : "true"); copyOfClientPayload.put("is_deviceid", (clientId == null) ? "true" : "false"); this.clientPayload = Collections.unmodifiableMap(copyOfClientPayload);}周围环境
{}不是严格必需的,但是它们限制了的范围copyOfClientPayload,因此您以后不能在构造函数中意外地重用它。



